[SHA3] Panic Freedom annotation improvements#162
Open
robinhundt wants to merge 5 commits into
Open
Conversation
robinhundt
force-pushed
the
robin/sha3-fstar-proof
branch
from
d625a8e to
13da43b
Compare
robinhundt
force-pushed
the
robin/sha3-fstar-proof
branch
from
13da43b to
ae94975
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the number of hax-lib annotations required for the SHA-3 panic freedom prove to go through.
The main change is in the second commit, which changes an if condition in
fill_buffer.With the previous version, the addition could panic on overflow which required extensive requires clauses
inputs.len().to_int() + self.buf_len.to_int() <= usize::MAX.to_int()for a large part of the call stack.By rewriting the condition to avoid the potential overflow, we can get rid of these requires.
I've also changed the panicking
From<u32>impl forAlgorithma TryFrom one. Neither of which is used in libcrux-sha3 (or any downstream crates in iot as far as I can tell), but it is good practice to have fallible conversions implement TryFrom and not From.