Skip to content

Core models option update#6

Merged
maximebuyse merged 5 commits into
devfrom
core-models-option
Jun 4, 2026
Merged

Core models option update#6
maximebuyse merged 5 commits into
devfrom
core-models-option

Conversation

@maximebuyse

Copy link
Copy Markdown

No description provided.

@maximebuyse maximebuyse marked this pull request as ready for review June 4, 2026 10:56
@maximebuyse maximebuyse requested a review from abentkamp June 4, 2026 10:56

@abentkamp abentkamp left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you urgently need this for your extractions, right? So let's merge it.

This will have a hard time to be upstreamed though, I think. Instead, we should start working on a sort of config-file that determines how exactly items from dependency crates are supposed to be extracted, as we discussed here: #Cryspen > ExtractBuiltinLean @ 💬

That would make your current code obsolete, right?

@maximebuyse

Copy link
Copy Markdown
Author

I assume you urgently need this for your extractions, right? So let's merge it.

This will have a hard time to be upstreamed though, I think. Instead, we should start working on a sort of config-file that determines how exactly items from dependency crates are supposed to be extracted, as we discussed here: #Cryspen > ExtractBuiltinLean @ 💬

That would make your current code obsolete, right?

Yes, this goes together with a PR for rust-core-models that relies on it. Indeed this should be temporary and replaced by a better solution like a TOML file specifying all special treatments.

@maximebuyse maximebuyse added this pull request to the merge queue Jun 4, 2026
Merged via the queue into dev with commit 157c25e Jun 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants