Core models option#2
Merged
Merged
Conversation
maximebuyse
force-pushed
the
core-models-option
branch
from
c34ab33 to
90d17d5
Compare
abentkamp
force-pushed
the
core-models-option
branch
from
97df742 to
210ed8c
Compare
karthikbhargavan
added a commit
that referenced
this pull request
May 19, 2026
CertObserver registers with the [Observer.current] slot from commit #1 when [-emit-cert] is set. Its [event_to_cert] dispatch is empty — commits 3-9 grow it one Event variant at a time. Until then, no inline emit site calls [Observer.notify], so cert output stays byte-equal (the existing [ctx_emit_event] -> [eval_ctx.cert_event_buffer] path is untouched). * src/cert/CertObserver.{ml,mli} — install / event_to_cert / on_event. on_event respects ctx.cert_events_suppressed so the migration in commit #6 (which moves the InterpLoops suppression call to Observer.with_suppressed) can swap atomically without intermediate drift. * src/Main.ml — call Aeneas.CertObserver.install () before CertGen.emit under -emit-cert. * src/dune — wire CertObserver, Event, Observer into the library's explicit (modules ...) list. (Event/Observer landed in commit #1 but had no consumer, so dune silently dropped them; CertObserver surfaces the dependency.) Gates: G_cert 89/89, G_build clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
maximebuyse
force-pushed
the
core-models-option
branch
from
210ed8c to
01a4ba3
Compare
…dels lean library.
maximebuyse
force-pushed
the
core-models-option
branch
from
2c0bf87 to
6bfa72b
Compare
abentkamp
reviewed
Jun 2, 2026
Comment on lines
+3130
to
+3135
| match | ||
| compute_allocator_filter | ||
| ~extra_trait_decl_refs:[ trait_impl.impl_trait ] | ||
| ~extra_trait_refs:trait_impl.parent_trait_refs trait_impl.generics | ||
| assoc_tys None trait_impl.preds | ||
| with |
There was a problem hiding this comment.
trait_impl has a couple of other fields such as consts and methods that are not looked into here. Maybe the type param could be used only in there?
|
I'd like to merge this now, although many of the changes will probably not be upstreamed in this form, right?
|
abentkamp
approved these changes
Jun 3, 2026
abentkamp
left a comment
abentkamp
left a comment
There was a problem hiding this comment.
@maximebuyse Please have a look at my comments above, but I am going to merge this anyway, so that we can make some progress in dependent repos.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
-core-models-optionflag to theaeneasbinary. Under this option, names and more will be produced to be compatible with the lean library provided inrust-core-models.