chore(archive): use TransferManager to archive active recording streams#1598
Merged
Merged
Conversation
Josh-Matsuoka
approved these changes
Jun 22, 2026
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
andrewazores
force-pushed
the
s3-transfermanager
branch
from
7b591c3 to
79da397
Compare
Member
Author
|
/build_test |
|
Workflow started at 6/22/2026, 1:33:58 PM. View Actions Run. |
|
CI build: |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainSee #1594
See #1596
See #1215
Description of the change:
Fixes a missed piece from #1215, removing the last direct usage of S3AsyncClient and using S3TransferManager where applicable instead. S3SyncClient is still directly used in cases like file metadata management rather than direct file storage.