Skip to content

fix(rule): reimplement Automated Rule activation using Quartz jobs#1547

Merged
andrewazores merged 15 commits into
cryostatio:mainfrom
andrewazores:rule-activation
Jun 15, 2026
Merged

fix(rule): reimplement Automated Rule activation using Quartz jobs#1547
andrewazores merged 15 commits into
cryostatio:mainfrom
andrewazores:rule-activation

Conversation

@andrewazores

@andrewazores andrewazores commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #1540

Description of the change:

  • removes in-memory RuleService blocking queues for Rule activation attempts
  • uses persisted Quartz jobs to manage Rule activation attempts
  • applies Smallrye fault tolerance to activation execution and cleanup execution actions, to improve the robustness of the actions performed by Rules

Motivation for the change:

See #1540 . This should improve the reliability and robustness of Automated Rule activations (starting recordings on matching targets) and cleanup.

How to manually test:

  1. Check out and build PR
  2. ./smoktest.bash -O -t quarkus-cryostat-agent,wildfly-28,spring-boot-3,vertx-cryostat-agent
  3. Try enabling and disabling preset Rules, creating custom Rules, etc. and ensure that recordings are started/stopped and periodically archived on all targets as expected

@github-actions github-actions Bot added dependent needs-triage Needs thorough attention from code reviewers labels May 26, 2026
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label May 26, 2026
@andrewazores andrewazores force-pushed the rule-activation branch 2 times, most recently from 76d5821 to b7253e9 Compare May 29, 2026 17:22
@andrewazores

andrewazores commented May 29, 2026

Copy link
Copy Markdown
Member Author

/build_test

@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown

Workflow started at 5/29/2026, 1:22:48 PM. View Actions Run.

@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown

CI build:
Integration tests pass ✅
Tests run: 46, Failures: 0, Errors: 0, Skipped: 1
https://github.com/cryostatio/cryostat/actions/runs/26651793146

@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown

CI build:
Unit tests pass with flaky tests ⚠️
Tests run: 564, Failures: 0, Errors: 0, Skipped: 1, Flakes: 1

Flaky tests:

@andrewazores andrewazores marked this pull request as ready for review June 2, 2026 18:05
@andrewazores andrewazores requested a review from a team as a code owner June 2, 2026 18:05
@andrewazores

andrewazores commented Jun 2, 2026

Copy link
Copy Markdown
Member Author

/build_test

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

Workflow started at 6/2/2026, 2:05:43 PM. View Actions Run.

@andrewazores andrewazores requested a review from a team June 2, 2026 18:06
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

CI build:
Integration tests pass ✅
Tests run: 46, Failures: 0, Errors: 0, Skipped: 1
https://github.com/cryostatio/cryostat/actions/runs/26838663325

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

CI build:
Unit tests pass ✅
Tests run: 564, Failures: 0, Errors: 0, Skipped: 1
https://github.com/cryostatio/cryostat/actions/runs/26838663325

Josh-Matsuoka
Josh-Matsuoka approved these changes Jun 15, 2026
View reviewed changes

@Josh-Matsuoka Josh-Matsuoka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not seeing any issues with rule activation in smoketest

@andrewazores

andrewazores commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

/build_test

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

Workflow started at 6/15/2026, 12:17:49 PM. View Actions Run.

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

CI build:
Integration tests pass ✅
Tests run: 46, Failures: 0, Errors: 0, Skipped: 3
https://github.com/cryostatio/cryostat/actions/runs/27560152086

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

CI build:
Unit tests pass with flaky tests ⚠️
Tests run: 599, Failures: 0, Errors: 0, Skipped: 1, Flakes: 1

Flaky tests:

@andrewazores andrewazores merged commit 0a3cf54 into cryostatio:main Jun 15, 2026
13 of 16 checks passed
@andrewazores andrewazores deleted the rule-activation branch June 15, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Josh-Matsuoka Josh-Matsuoka Josh-Matsuoka approved these changes

@ebaron ebaron ebaron approved these changes

Assignees

No one assigned

Labels

fix safe-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Intermittent Automated Rule activation failure

3 participants

@andrewazores @Josh-Matsuoka @ebaron