Repository navigation
Fix cross-request header leakage in proxy - #211
Merged
Merged
Conversation
commit: |
Fryuni
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The proxy temporarily replaced the shared
NextResponse.nextmethod while awaiting application middleware. Overlapping requests could inherit another visitor's headers, including a preview token. Out-of-order completion could also leave a stale wrapper installed after both requests finished.Solution and guarantees
Replace per-request patching/restoration with a stable interceptor backed by Next's
AsyncLocalStorage.fetchContent()fail.This isolates Croct's automatic forwarding while preserving the public API, header precedence, dependencies, and supported runtime ranges. Production changes are limited to the proxy and its internal context helper.
Validation
Randomizing the entire suite exposes a pre-existing console-mock order dependency in
fetchContent.test.ts, reproduced independently and left outside this fix.The integration/load harness was used locally; this PR includes only the fix and focused source regression tests. Deployment-specific staging validation remains a release step.