Repository navigation
Conversation
When the borrowed site stopped answering, the splice closed with a FIN after swallowing a ClientHello, while Warren clients went on being served: one address with two behaviours, separable with no key. The warm pool now keeps a reachability verdict from its dials (two consecutive failures mark the site down, any success brings it back). While the site is down, serveConn resets every new connection before reading, Warren clients included, and a splice whose dial fails resets instead of closing cleanly. The background filler keeps dialing, so the relay recovers without a restart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ROADMAP H8 — silent failure when the borrowed site is unreachable.
Problem
When the borrowed site stopped answering, the splice's dial failed and the relay closed with a FIN after accepting the connection and swallowing a ClientHello. Meanwhile Warren clients kept being served, so one relay address had two behaviours: some connections became long TLS sessions, every other one got nothing. That is separable with no key.
Change
warmpool.go: the pool keeps a reachability verdict from its dials.siteDownAfter(2) consecutive failures, from the background filler or a splice's fresh dial, mark the site down. Any success brings it back. Dials abandoned on shutdown are not counted.camouflage.go:serveConnresets every new connection before reading, Warren clients included.resetClosehelper.Known residuals (documented in ROADMAP/CHANGELOG)
Servedoesn't own it (API change, out of scope here).Tests (
sitedown_test.go)Both behaviour tests were checked against the fix reverted and fail. The splice test first passed for the wrong reason: closing a socket with unread data makes the kernel RST on its own. It now consumes the request first, like
serveConn's peek.Locally (Windows):
go build,go vet,go test ./...and LF-normalisedgofmtall pass.-raceis not available here, so CI covers it.🤖 Generated with Claude Code