Verify criipto metadata#36
Merged
Merged
Conversation
This allows consumers to easily check if the error comes from our SDK, using `err instanceof IduraSDKError`. This commit also changes all existing error to extend the base class.
…figured domain or client ID. When calling fetchMetadata, we now try to catch and warn the user about the most common failure modes. This will not catch all domain errors, because the fetch might fail due to CORS, which we cannot easily distinquish from other network related errors. But it's a lot better than nothing
✅ Deploy Preview for rainbow-trifle-ec1333 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
janmeier
commented
Mar 24, 2026
| export class PromiseCancelledError extends IduraSDKError { | ||
| constructor() { | ||
| super("Promise cancelled"); | ||
| Object.setPrototypeOf(this, PromiseCancelledError.prototype); |
Collaborator
Author
There was a problem hiding this comment.
This is only required for es5
Collaborator
There was a problem hiding this comment.
@janmeier I thought it was generally required per the TS docs?
Collaborator
Author
There was a problem hiding this comment.
https://www.typescriptlang.org/docs/handbook/2/classes.html#inheriting-built-in-types
Note: If you don’t plan to inherit from built-in types like Array, Error, Map, etc. or your compilation target is explicitly set to ES6/ES2015 or above, you may skip this section
mickhansen
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation for misconfigured domain or client ID.
When calling fetchMetadata, we now try to catch and warn the user about the most common failure modes. This will not catch all domain errors, because the fetch might fail due to CORS, which we cannot easily distinquish from other network related errors. But it's a lot better than nothing