Skip to content

Improve Sequential Ordering: H5s into H3s#22

Open
airbr wants to merge 2 commits into
crickets-and-comb:mainfrom
airbr:develop-1
Open

Improve Sequential Ordering: H5s into H3s#22
airbr wants to merge 2 commits into
crickets-and-comb:mainfrom
airbr:develop-1

Conversation

@airbr

@airbr airbr commented Apr 15, 2025

Copy link
Copy Markdown

This small change will make a small difference to improve the accessibility of the site.

Tested locally with Lighthouse
Screenshot 2025-04-14 at 6 35 24 PM

Addresses issue: #23

@github-actions github-actions Bot closed this Apr 15, 2025
@github-actions

Copy link
Copy Markdown

Pull request closed

Hi @airbr, this PR was closed automatically. Reason: Only members of crickets-and-comb or explicitly allowed users can open pull requests. Please file an issue for discussion if needed.

@KalebCoberly

Copy link
Copy Markdown
Contributor

Alright, @airbr, I've added you to the list of allowed users to submit a PR without it being autoclosed. You're the first outside contributor I've added to the list, so we'll see how it works! 🤞

@KalebCoberly KalebCoberly reopened this Apr 15, 2025
@KalebCoberly

Copy link
Copy Markdown
Contributor

@airbr , it looks like you need to set up your git commit signature. You should be able to find the instructions in the GitHub docs. That said, I think you'll need to redo the PR with all new commits since you can't retroactively add your signature to commits ... I think.

@airbr

airbr commented Apr 15, 2025

Copy link
Copy Markdown
Author

@airbr , it looks like you need to set up your git commit signature. You should be able to find the instructions in the GitHub docs. That said, I think you'll need to redo the PR with all new commits since you can't retroactively add your signature to commits ... I think.

You run a tight ship here! Impressed.

I have set up this computer not long ago so Ill have to do some futzing about to get this all signed and reuploaded into a new PR. Its a minor thing though to a landing page so no rush I think :)

@KalebCoberly

Copy link
Copy Markdown
Contributor

Other than that, the page seems to be working fine, and the objective appears met (see lighthouse reports). Thanks for doing this! And, thanks for showing me Lighthouse. It's pretty nifty. I'm thinking about incorporating it into a workflow for website repo PRs.
Screenshot 2025-04-14 at 9 08 53 PM
Screenshot 2025-04-14 at 9 09 15 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants