feat: Google Play Store deploy workflow#53
Merged
Conversation
- D5: VCard import (VCardParser, ContactsViewModel.importVCard, ContactsScreen import button) - E2/E3: Contact dedup (ContactDeduplicator exact + fuzzy) and merge UI (ViewModel merge/dismiss, Screen banner + dialog) - D1/D3: Confidence badge + error classification (ScanScreen, ScanViewModel) - Stream G tests: VCardParserTest (11), ContactDeduplicatorTest (15), ContactsViewModelTest (6), ContactsTest (+3 instrumented) - Build fix: Java 17, Ezvcard.parse().all(), MaterialTheme.colorScheme.error - Added kotlinx-coroutines-test + core-testing deps
- New workflow: play-store-deploy.yml with manual dispatch - Supports internal/alpha/beta/production tracks - Builds signed AAB with release keystore - Uploads via r0adkll/upload-google-play action - Added release signingConfig to build.gradle.kts Required GitHub Secrets: - PLAY_STORE_KEYSTORE_BASE64 (base64 encoded .keystore) - PLAY_STORE_KEYSTORE_PASSWORD - PLAY_STORE_KEY_ALIAS - PLAY_STORE_KEY_PASSWORD - PLAY_STORE_SERVICE_ACCOUNT_JSON (Play Console service account with release permission)
| val edges = (0 until 4).map { i -> | ||
| val (x1, y1) = corners[i] | ||
| val (x2, y2) = corners[(i + 1) % 4] | ||
| sqrt((x2 - x1) * (x2 - x1) + (y2 - y1) * (y2 - y1)) |
| val p2x = srcPoints[4]; val p2y = srcPoints[5] | ||
| val p3x = srcPoints[6]; val p3y = srcPoints[7] | ||
|
|
||
| val topW = sqrt((p1x - p0x) * (p1x - p0x) + (p1y - p0y) * (p1y - p0y)) |
| val p3x = srcPoints[6]; val p3y = srcPoints[7] | ||
|
|
||
| val topW = sqrt((p1x - p0x) * (p1x - p0x) + (p1y - p0y) * (p1y - p0y)) | ||
| val bottomW = sqrt((p2x - p3x) * (p2x - p3x) + (p2y - p3y) * (p2y - p3y)) |
|
|
||
| val topW = sqrt((p1x - p0x) * (p1x - p0x) + (p1y - p0y) * (p1y - p0y)) | ||
| val bottomW = sqrt((p2x - p3x) * (p2x - p3x) + (p2y - p3y) * (p2y - p3y)) | ||
| val leftH = sqrt((p3x - p0x) * (p3x - p0x) + (p3y - p0y) * (p3y - p0y)) |
| val topW = sqrt((p1x - p0x) * (p1x - p0x) + (p1y - p0y) * (p1y - p0y)) | ||
| val bottomW = sqrt((p2x - p3x) * (p2x - p3x) + (p2y - p3y) * (p2y - p3y)) | ||
| val leftH = sqrt((p3x - p0x) * (p3x - p0x) + (p3y - p0y) * (p3y - p0y)) | ||
| val rightH = sqrt((p2x - p1x) * (p2x - p1x) + (p2y - p1y) * (p2y - p1y)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Google Play Store deployment workflow added.
Changes:
New workflow:
.github/workflows/play-store-deploy.ymlr0adkll/upload-google-playactionbuild.gradle.kts: Added release
signingConfigusing env varsRequired GitHub Secrets (configure in repo settings):
PLAY_STORE_KEYSTORE_BASE64base64 -w0 release.keystore)PLAY_STORE_KEYSTORE_PASSWORDPLAY_STORE_KEY_ALIASPLAY_STORE_KEY_PASSWORDPLAY_STORE_SERVICE_ACCOUNT_JSONreleasepermissionUsage:
Prerequisites:
com.cardsnapRelease Managerrolekeytool -genkey -v -keystore release.keystore -alias cardsnap -keyalg RSA -keysize 2048 -validity 10000)Verification: