fix: complete CardSnap rebranding - add screenshots and fix remaining issues#24
Closed
rprabhat wants to merge 4 commits into
Closed
fix: complete CardSnap rebranding - add screenshots and fix remaining issues#24rprabhat wants to merge 4 commits into
rprabhat wants to merge 4 commits into
Conversation
rprabhat
force-pushed
the
fix/final-cardsnap-cleanup
branch
from
a0cd59e to
7cea79b
Compare
- Add GitHub Pages landing page (docs/index.html) - Add 4 SVG app screenshots (scan, review, contacts, settings) - Update .gitignore to allow docs/index.html and screenshots - Fix PRIVACY_POLICY.md for native Kotlin Android (remove RN/iOS refs) - Remove all React Native references from Gradle configs - Ensure deep link scheme is cardsnap:// (not cardscanner://) - Fix package.json keyword to card-snap - Update CODE_OF_CONDUCT.md to Contributor Covenant v2.1 Co-Authored-By: Claude <noreply@anthropic.com>
rprabhat
force-pushed
the
fix/final-cardsnap-cleanup
branch
from
7cea79b to
70ebd12
Compare
Collaborator
Author
|
Closing - gradle conversion from Kotlin DSL to Groovy DSL has fundamental issues requiring RN/Android expertise to resolve. This is a rebranding PR, not a Sensible standards compliance issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete the CardSnap rebranding by addressing all Oracle verification findings.
Changes
docs/images/screenshots/:scan-screen.svg- Camera scan screenreview-contact.svg- Contact review/edit screencontacts-list.svg- Contacts listsettings.svg- Settings screencom.facebook.react,react-native, andnode_modulesreferences removedcardscanner://→cardsnap://card-scanner→card-snapAI Disclosure