fix(tasks): rename json property to json_output to avoid BaseModel method conflict#6553
Open
bunnysayzz wants to merge 1 commit into
Open
fix(tasks): rename json property to json_output to avoid BaseModel method conflict#6553bunnysayzz wants to merge 1 commit into
bunnysayzz wants to merge 1 commit into
Conversation
…thod conflict The TaskOutput and CrewOutput classes inherit from Pydantic's BaseModel, which provides a built-in .json() method. Both classes defined a @Property named 'json' which shadowed BaseModel.json(), causing serialization conflicts. This renames the property to 'json_output' and updates all references. Closes the TODO comment in task_output.py that acknowledged this issue.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughRenames ChangesJSON output API
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Both
TaskOutputandCrewOutputinherit from Pydantic'sBaseModel, which provides a built-in.json()method. Both classes defined a@propertynamedjsonwhich shadowedBaseModel.json(), causing serialization conflicts.This was acknowledged by a TODO comment in
task_output.py.Changes
@property def jsonto@property def json_output, removed the TODO comment and# type: ignore[override]@property def jsonto@property def json_output, removed the# type: ignore[override], added a docstringresult.jsontoresult.json_output, renamed test for consistencyTesting
BaseModel.json()method is now accessible again