Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/cli/src/crewai_cli/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,11 +258,11 @@
"nvidia_nim/baichuan-inc/baichuan2-13b-chat",
],
"groq": [
"groq/llama-3.3-70b-versatile",
"groq/llama-3.1-8b-instant",
"groq/llama-3.1-70b-versatile",
"groq/llama-3.1-405b-reasoning",
"groq/gemma2-9b-it",
"groq/gemma-7b-it",
"groq/meta-llama/llama-4-scout-17b-16e-instruct",
"groq/qwen/qwen3-32b",
"groq/allam-2-7b",
Comment on lines +261 to +265

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Keep Groq model IDs synchronized across CLI creation paths.

Line 261 updates MODELS["groq"], but lib/cli/src/crewai_cli/create_json_crew.py still has a separate stale Groq list (including removed IDs like llama-3.1-70b-versatile). This can let JSON crew flow select unavailable models. Please update that list in the same PR, or source it from MODELS["groq"] to prevent drift.

Suggested direction
-# create_json_crew.py (hardcoded groq list)
-"groq": [
-    ("llama-3.3-70b-versatile", "Llama 3.3 70B"),
-    ("llama-3.1-70b-versatile", "Llama 3.1 70B"),
-    ...
-],
+# Prefer deriving from constants.MODELS["groq"] (single source of truth)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/cli/src/crewai_cli/constants.py` around lines 261 - 265, The Groq model
list is duplicated and has drifted between the CLI constants and the JSON crew
creation flow, so update the stale Groq IDs in create_json_crew.py to match
MODELS["groq"] from constants.py, or refactor the JSON crew path to source the
list directly from MODELS["groq"]. Use the existing symbols MODELS["groq"] and
the Groq model selection logic in create_json_crew.py to locate and align the
shared model IDs.

],
"ollama": ["ollama/llama3.1", "ollama/mixtral"],
"watson": [
Expand Down