fix(agents): proxy human input flag through executor state#6067
fix(agents): proxy human input flag through executor state#6067fengjikui wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds a getter/setter property to Changesask_for_human_input Compatibility
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I attempted to add the required |
|
Closing this duplicate in favor of #6069, which contains the same fix with stronger validation and the human-input provider regression test. |
Summary
AgentExecutor.ask_for_human_inputas a compatibility property backed byAgentExecutorStateWhy
SyncHumanInputProvideraccessescontext.ask_for_human_inputdirectly, but the experimentalAgentExecutorstores the flag only onself.state. WithTask(human_input=True), that mismatch raisesAttributeErrorbefore the feedback loop can run.Fixes #6065.
Validation
python3 -m py_compile lib/crewai/src/crewai/experimental/agent_executor.py lib/crewai/tests/agents/test_agent_executor.pyI was not able to run the targeted pytest locally because cloning/checking out the full repository repeatedly failed on this machine with network EOF errors; the change is limited to a state-backed compatibility property plus a focused unit test.
AI assistance disclosure
This PR was prepared with AI assistance and reviewed before submission.
Summary by CodeRabbit
New Features
Tests