Repository navigation
Add CSS isolation support to SVG frames - #244
Merged
noelwelsh merged 1 commit intoOct 10, 2026
Merged
Conversation
Expose isolation on Frame and serialize it on the root SVG. Document usage and cover frame style output. Co-authored-by: Arnav Sharma <170600828+arnavsharma990@users.noreply.github.com>
Contributor
|
Thanks. Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users who need CSS isolation for Doodle SVG output cannot set it through
Frame, so the root SVG has no isolation style declaration.This picks up #233 by @arnavsharma990. It carries their frame option, SVG style output, and tests.
For @noelwelsh's requested changes, the isolation values are now a Scala 3 enum, the SVG guide shows how to set isolation, and the unrelated
Layout.Scalarchanges are absent. The existing path rendering test is preserved. One table of SVG style cases covers both frame sizes, both isolation values, and backgrounds.The
testtask reported 376 passing test executions across 16 summaries on Java 17, with no failures. Header and formatting checks, API documentation, and the site build passed. RestoringSvg.scalafrom main makes the isolation test fail: its actual SVG style ispointer-events: bounding-box;without an isolation declaration.This adds a fourth field to the public
Framecase class. The project's binary compatibility task reports no previous SVG artifact configured, so it cannot compare the case class against an older release.githubWorkflowCheckreports the same generated-workflow mismatch on this branch and untouched main.Closes #228.
I am glad to close this if @arnavsharma990 would rather finish theirs.