Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
florinutz
force-pushed
the
flo/320/testcontainers-upstream
branch
from
October 9, 2026 18:49
a21ca56 to
1dbc038
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlalchemy-cratedb's tests start crate through cratedb-toolkit, and the toolkit depends on sqlalchemy-cratedb, so a change here can break the suite until both packages release (#320, crate/cratedb-toolkit#913).
The
cratedb_servicefixture now starts crate from theCrateDBContainerclass of testcontainers, through a smallCrateDBTestAdapterintests/util.py. It holds the engine and the SQL helpers used by the tests (run_sql,refresh_table,count_records), so thetestextra installstestcontainers>=4.15,<5andhttpxinstead ofcratedb-toolkit[testing]. The extra lists those two rather thantestcontainers[cratedb], because that extra also installs sqlalchemy-cratedb from PyPI. The tests would then depend on a released copy of this package again.The fixture runs the crate version from
CRATEDB_VERSION(nightly by default). Nightly comes fromcrate/crate:nightly, and a released version comes from the officialcrate:<version>image, because the release tags ofcrate/crateare amd64-only.Closes #320.