Conversation
There was a problem hiding this comment.
🟡 Changes recommended
memdx::Dispatcher::dispatch currently uses RequestPacket without the required lifetime parameter for RequestPacket<'a>, which will fail to compile.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR removes the async-trait dependency from couchbase-core by transitioning async trait methods to return impl Future, aligning the SDK with native async-in-trait/RPITIT patterns.
Changes:
- Removed
async-traitimports/usages across retry/query/analytics components. - Updated
memdx::Dispatcherandhttpx::Clienttraits to usefn ... -> impl Futureinstead ofasync fnviaasync-trait. - Dropped the
async-traitdependency fromsdk/couchbase-core/Cargo.toml.
File summaries
| File | Description |
|---|---|
| sdk/couchbase-core/src/retry.rs | Removes unused async-trait import as part of dependency drop. |
| sdk/couchbase-core/src/queryx/query_respreader.rs | Removes unused async-trait import as part of dependency drop. |
| sdk/couchbase-core/src/memdx/dispatcher.rs | Refactors Dispatcher trait away from async-trait to impl Future returns. |
| sdk/couchbase-core/src/memdx/client.rs | Removes async-trait usage from the Dispatcher implementation site. |
| sdk/couchbase-core/src/httpx/client.rs | Refactors HTTP client trait to return impl Future and removes async-trait. |
| sdk/couchbase-core/src/analyticsx/query_respreader.rs | Removes unused async-trait import as part of dependency drop. |
| sdk/couchbase-core/Cargo.toml | Removes the async-trait dependency. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Bencher Report| Project | couchbase-rs |
| Branch | RSCBC-295-34506859750-210-1 |
| Testbed | ubuntu-latest |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| upsert_and_get | Latency microseconds (µs) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 447.54 µs(+16.01%)Baseline: 385.79 µs | 443.66 µs (100.88%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| query | 📈 view plot 🚷 view threshold | 440.85 µs(+5.41%)Baseline: 418.22 µs | 480.95 µs (91.66%) |
| upsert_and_get | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 447.54 µs(+16.01%)Baseline: 385.79 µs | 443.66 µs (100.88%) |
|
| Project | couchbase-rs |
| Branch | RSCBC-295-34507982510-211-1 |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| query | 📈 view plot 🚷 view threshold | 335.21 µs(-19.85%)Baseline: 418.22 µs | 480.95 µs (69.70%) |
| upsert_and_get | 📈 view plot 🚷 view threshold | 184.00 µs(-52.31%)Baseline: 385.79 µs | 443.66 µs (41.47%) |
|
| Project | couchbase-rs |
| Branch | RSCBC-295-34589230955-212-1 |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| query | 📈 view plot 🚷 view threshold | 446.55 µs(+6.78%)Baseline: 418.22 µs | 480.95 µs (92.85%) |
| upsert_and_get | 📈 view plot 🚷 view threshold | 428.21 µs(+11.00%)Baseline: 385.79 µs | 443.66 µs (96.52%) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.