Repository navigation
test(box): the review test no longer fails when a commit's hash ends in 0 - #55
Merged
Merged
Conversation
…in 0 It made an "unseen" commit by replacing the last digit of the real one with 0, so one run in sixteen asked to update to the commit already checked out and was, rightly, not refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestAReviewIsMadeAtTheConfirmedCommitAndNothingElsemade an "unseen" commit by replacing the last digit of the real hash with0. When the real hash already ended in0, that was the same commit, the update was (rightly) not refused, and the test failed: about one run in sixteen. It failed full local runs on two unrelated branches today.The unseen hash now differs in its last digit whatever that digit is.
Checked:
go vet ./internal/box/and the test with-race -count=40, all pass. Test-only change.🤖 Generated with Claude Code