Fix IaC rule activation by adding HCL/Terraform language mapping#90
Merged
thomas-bartlett merged 1 commit intoJun 9, 2026
Merged
Conversation
Bug: the codeguard-0-iac-security rule lists hcl as a target language
and addresses Terraform, but language_mappings.py had no hcl entry, so
the rule never matched .tf/.tfvars files and never activated on
Terraform code.
Fix: add the hcl -> [.tf, .tfvars, .tf.json, .hcl] mapping and add hcl
to the source rule's languages list.
Regenerated the committed skills/ output to match source with:
python src/convert_to_ide_formats.py
|
|
thomas-bartlett
approved these changes
Jun 9, 2026
thomas-bartlett
left a comment
thomas-bartlett
left a comment
Contributor
There was a problem hiding this comment.
Thank you for fixing this, looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The
codeguard-0-iac-securityrule listshclas a target language and the rule explicitly addresses Terraform, butsrc/language_mappings.pyhad nohclentry. As a result the rule never matched.tf/.tfvarsfiles and effectively never activated on Terraform code.Fix
Two coordinated edits:
"hcl": [".tf", ".tfvars", ".tf.json", ".hcl"]tosrc/language_mappings.py.- hclto thelanguageslist in the source rulesources/rules/core/codeguard-0-iac-security.md(alphabetical;tagsuntouched).Generated output
Regenerated the committed
skills/software-security/bundle so the generated copy matches source:dist/is gitignored and not committed.Validation
python src/validate_unified_rules.py— 109 passed, 0 failedpython src/validate_versions.py— all versions match (1.3.1); no version bump needed since no versioned files changed.