Repository navigation
ASAN Fixes - #295
Open
Causeless wants to merge 2 commits into
Open
ASAN Fixes#295Causeless wants to merge 2 commits into
Causeless wants to merge 2 commits into
Conversation
… was destroyed A SoundContainer that gets destroyed while its sounds are playing leaves them to play out, which emitters for one count on for their burst and end sounds. The channels playing them kept pointing at the destroyed SoundContainer though, and it then got used every update for the channels' 3D effects, and once more when the sounds ended. AddressSanitizer reports these as uses after free. Destroying a SoundContainer now unties its channels from it. Sounds that loop endlessly get stopped instead, since there'd be nothing left to stop them with, and the ones left to play out stay the way they were, with their 3D effects no longer updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…uipping it When told to put what the BG arm was holding at the front of the inventory, it went on to use the place it had found the device at before doing so, which by then was the place of the item in front of it. That item got taken out of the inventory instead, never to be seen again, and the device ended up both held and in the inventory. Its holder dying then dropped it twice over, which left MovableMan with it in its list of items twice, and the game deleting it twice when quitting. Lua could get this on any call, since its binding cast the function to one without that argument, which left the argument as whatever happened to be in its place. It is bound through an adapter now, which leaves the argument at its default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for memory errors that turned up while running headless AI battles on the
deterministic-simbranch.🤖 Generated with Claude Code