Repository navigation
Conversation
fderop
marked this pull request as ready for review
October 2, 2026 18:28
Causeless
enabled auto-merge
October 3, 2026 18:54
Contributor
|
Not sure we want to include the benchmarks stuff, but I don't see an issue with it for now |
Causeless
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sprite collision queries copied rotation matrices but discarded their cached coefficients, so later transforms repeated sine and cosine calculations.
The copy now preserves the coefficients and their validity flag:
Valid caches remain valid. Invalid caches still recalculate on use.
MOSprite::HitTestAtPixelalso drops its redundant matrix copy. The existing const operator retains a local copy, so queries do not mutate shared matrices.Three process pairs on an M3 Pro with GCC 15.2 show 10.7–24.6% less collision-query time, depending on cache state.
All 29,491,200 pixel-query results and matrix float-bit hashes match. Concurrent-reader checks and full release builds pass.
These are function timings, not FPS gains.
Only
Matrix.cppandMOSprite.cppchange in production. Fixture and reproduction instructions.