Adding docker image templates #175
Conversation
|
How did you test that all of the docker files are updated correctly? |
| && yum clean all | ||
|
|
||
| ENV LANG C.UTF-8 | ||
| ENV JAVA_HOME=/usr/lib/jvm/java-{{MAJOR_VERSION}}-amazon-corretto |
There was a problem hiding this comment.
Think when it is JDK8 you need to use 1.8.0 for the java_home and not just the major_version.
There was a problem hiding this comment.
right I will fix it
| && CORRETO_TEMP=$(mktemp -d) \ | ||
| && pushd ${CORRETO_TEMP} \ | ||
| {% if jre %} | ||
| && RPM_LIST=("java-{{JDK_VERSION}}-amazon-corretto-$version.amzn2.$(uname -m).rpm") \ |
There was a problem hiding this comment.
I think it would simplify the code if you eliminate JDK_VERSION and just set MAJOR_VERSION to 1.8.0 when its 8. Is that possible or are those values too overloaded?
There was a problem hiding this comment.
I can try that and see if everything builds correctly
verify_update func checks the updated images count, update: verified manually docker images build as expected (to the images currently in repo) |
lutkerd
left a comment
lutkerd
left a comment
There was a problem hiding this comment.
Please run apply-templace and include any changes to generated Dockerfiles.
2 participants
Issue #, if available:
Description of changes:
Currently docker image template is available for alpine only
creating similar templates for the following platforms,
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.