fix(segmentation): replace unbounded render queue with coalescing Set#2674
Draft
pedrokohler wants to merge 1 commit into
Draft
fix(segmentation): replace unbounded render queue with coalescing Set#2674pedrokohler wants to merge 1 commit into
pedrokohler wants to merge 1 commit into
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
SegmentationRenderingEngine._pendingRenderQueueis astring[][]that growswithout bound. Every scroll event on a StackViewport with segmentations appends a
new viewport-ID array to the queue. The queue is drained one entry per animation
frame via
shift(), but entries arrive far faster than they are consumed.After 310 scroll events on a viewport with 13 labelmap segmentations, the queue
held 4,077 entries — each an array of 13+ viewport IDs with associated
closures and promise chains — consuming significant memory and CPU.
Changes & Results
Replace
_pendingRenderQueue: string[][] = []with_pendingRender: Set<string> = new Set().Set is cleared.
O(viewports)instead ofO(scroll events).Before: queue grows linearly with scroll events (4,077 entries after 310 scrolls).
After: pending set stays bounded at the number of unique viewport IDs (e.g. 13).
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Made with Cursor