type hint fixes Iterable[Kernel] -> Kernel#2678
Merged
Merged
Conversation
Balandat
force-pushed
the
additive-kernel-type-hints
branch
from
November 14, 2025 21:02
05850c4 to
d320315
Compare
Balandat
enabled auto-merge
November 14, 2025 21:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2676, i.e., the type hint errors in the constructors of
AdditiveKernelandProductKernel.I did a grep search, and it seems that there are no types mistakenly annotated as
Iterable[Kernel]anymore. In the future, these type errors would be spotted more easily if we enforce strict type checking.