Repository navigation
fix: FP when being redirected to wp-admin on login - #114
Merged
Merged
Conversation
EsadCetiner
reviewed
Oct 4, 2026
EsadCetiner
left a comment
EsadCetiner
left a comment
Member
There was a problem hiding this comment.
Your test also fires against rules 932236 and 942120, can you disable those too for ARGS:redirect_to?
Member
|
Also, can you change your PR title to something more descriptive? |
Member
Author
Feel free to change it. |
EsadCetiner
reviewed
Oct 4, 2026
EsadCetiner
left a comment
EsadCetiner
left a comment
Member
There was a problem hiding this comment.
I don't have enough information to write a good PR title, where did this false positive come from exactly? Only PR title I could suggest is fix: fp when being redirected to wp-admin on login
azurit
changed the title
EsadCetiner
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.