This repository was archived by the owner on May 7, 2021. It is now read-only.
platform: add OpenStack#919
Merged
Merged
Conversation
Contributor
Author
|
Could not rebase this cleanly as even on just current master a |
cgwalters
reviewed
Sep 21, 2018
cgwalters
left a comment
cgwalters
left a comment
Member
There was a problem hiding this comment.
Only gave this a quick scan...seems reasonable offhand FWIW.
| func init() { | ||
| OpenStack.AddCommand(cmdCreate) | ||
| cmdCreate.Flags().StringVar(&path, "file", | ||
| sdk.BuildRoot()+"/images/amd64-usr/latest/coreos_production_openstack_image.img", |
Member
There was a problem hiding this comment.
Just a note, we should start thinking about how this type of stuff intersects with coreos-assembler which has a different build layout and naming convention. But doesn't block this.
Contributor
|
bump |
Contributor
Author
|
⬆️ rebased |
bgilbert
reviewed
Dec 22, 2018
bgilbert
left a comment
bgilbert
left a comment
Contributor
There was a problem hiding this comment.
No major issues. Thanks for your patience.
Contributor
Author
|
Updated based on comments, rebased, and pushed ⬆️ |
bgilbert
reviewed
Jan 9, 2019
Adds the OpenStack Cluster, Flight & Machine interfaces.
Contributor
Author
|
Updated. |
…Configs These tests have to be switched from straight Ignition configs to Container Linux Configs to support OpenStack as the default OEM shipped by Container Linux is openstack but coreos-metadata requires the oem.id openstack-metadata which is supplied by default by CT.
coreos-metadata-sshkeys does not run on OpenStack by default as the oem.id for it to run is openstack-metadata and the default one shipped by Container Linux is openstack (as the base image cannot know if a metadata endpoint will be present).
bgilbert
approved these changes
Jan 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the OpenStack platform.
This currently requires a patch (coreos/coreos-overlay#3415) for
coreos.ignition.v2_2.security.tlsto pass.