translate: allow special mode bits in v34tov33 translation#62
Closed
prestist wants to merge 1 commit into
Closed
Conversation
Previously, the v34tov33 translator would error if special mode bits (setuid/setgid/sticky) were present in file or directory modes. This prevented down-translation of valid v3.4 configs. The translator already had the correct logic to mask out special mode bits during translation (since v3.3 doesn't support them), but the validation was preventing that code from running. This fix removes the validation checks and allows the translation to proceed, with special mode bits being masked out as intended. Fixes coreos#61 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
prestist
force-pushed
the
worktree-issue-61-special-mode-bits
branch
from
d4375a6 to
a5b5048
Compare
Member
|
I think this looks good. Let's merge it with the other PR to re-add the downgrade failure for the new spec. |
Contributor
Author
|
Merged into #58 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the v34tov33 translator would error if special mode bits (setuid/setgid/sticky) were present in file or directory modes. This prevented down-translation of valid v3.4 configs.
The translator already had the correct logic to mask out special mode bits during translation (since v3.3 doesn't support them), but the validation was preventing that code from running.
This fix removes the validation checks and allows the translation to proceed, with special mode bits being masked out as intended.
Fixes #61