Consistently use *Version in exported API (fixes #20)#21
Open
alexanderwilling wants to merge 2 commits into
Open
Consistently use *Version in exported API (fixes #20)#21alexanderwilling wants to merge 2 commits into
alexanderwilling wants to merge 2 commits into
Conversation
Author
|
If you want I can squash the fix commit and force-push, but I think it's easier to squash-merge in case this PR is accepted. |
alexanderwilling
changed the title
alexanderwilling
changed the title
|
Any updates about this PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request defines all exported methods on the Version type as taking a pointer receiver. Also, all exported methods that accept a version parameter now accept a
*Version, which is whatNew()andNewVersion()already returned.(As a side effect this addresses the weirdness that previously,
Versionimplemented thejson.Marshalerinterface, while*Versionimplemented thejson.Unmarshalerinterface.)