Skip to content

Dockerfile: update to Fedora 44#701

Merged
travier merged 1 commit into
coreos:mainfrom
marmijo:update-f44
May 20, 2026
Merged

Dockerfile: update to Fedora 44#701
travier merged 1 commit into
coreos:mainfrom
marmijo:update-f44

Conversation

@marmijo

@marmijo marmijo commented May 8, 2026

Copy link
Copy Markdown
Member

@marmijo marmijo added the skip-notes This PR does not need release notes label May 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the builder stage in the Dockerfile from Fedora 43 to Fedora 44. Feedback indicates that this update is incomplete because the runtime stage still references Fedora 43, which should be updated to maintain consistency across the multi-stage build.

Comment thread Dockerfile
@@ -1,4 +1,4 @@
FROM quay.io/fedora/fedora:43 AS builder
FROM quay.io/fedora/fedora:44 AS builder

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The update to Fedora 44 is incomplete. While the builder stage has been updated to version 44, the runtime stage (line 8) is still using quay.io/fedora/fedora-minimal:43. Both stages should be updated to maintain consistency and ensure the final image uses the intended Fedora version.

@prestist prestist left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need to update that to 44 too right?

Comment thread Dockerfile Outdated
@travier travier merged commit 85a7edd into coreos:main May 20, 2026
8 checks passed
@prestist prestist mentioned this pull request May 20, 2026
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-notes This PR does not need release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants