Skip to content

[16.0][MIG] container_meals: Migration to 16.0#382

Merged
github-grap-bot merged 54 commits into
16.0from
16.0-mig-container_meals
Jun 9, 2026
Merged

[16.0][MIG] container_meals: Migration to 16.0#382
github-grap-bot merged 54 commits into
16.0from
16.0-mig-container_meals

Conversation

@mihien

@mihien mihien commented Oct 22, 2025

Copy link
Copy Markdown
Member

@polchampion polchampion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mihien tested on cookingo-test
some tests were unsuccessful

  • Creates an “Is Meal?” button for meal products, which enables the user to set the volumes of a single portion for containers 1 and 2.
  • Adds a portion size product category product variant attribute. Child portions have 2/3 the volume of adult portions. This module does not adjust the price of child portions.
  • Adds an “Is Container?” button for container products, which enables the user to set the volume of the container.
  • Keeps track of the built up deposit by customers across sales, in the deposit tab on the customer contacts
  • Allows the user to set unreturned containers on sale orders in the "deposit" tab on contacts
    . All containers are assumed to be returned, and must be manually flagged as unreturned. Unreturned containers can be found on a customer’s contact view and in a special “Unreturned Containers” menu under Sales.
  • Calculates and automatically adds the containers needed to hold the to-purchase meals on the purchase page and
  • applies a discount depending on the customer’s current stored deposit

@mihien mihien force-pushed the 16.0-mig-container_meals branch 3 times, most recently from 9d45051 to 011f75e Compare November 18, 2025 10:35

@polchampion polchampion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all functional tests are successful

@remytms

remytms commented Nov 24, 2025

Copy link
Copy Markdown
Member

Depends on this : OCA/product-attribute#2110

@remytms remytms left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

…emplate

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
…ring installation

During installation, the _compute_container_volume is executed for all
products. Apparently the XML ID 'cookingo_custom.child_portion' is not
yet available at that time, causing an error. This commit circumvents
that error.

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
… volumes

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
…roduct

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
carmenbianca and others added 16 commits June 8, 2026 16:51
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
…to the biggest container

Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
@huguesdk huguesdk force-pushed the 16.0-mig-container_meals branch from 011f75e to 0407366 Compare June 8, 2026 15:04
@huguesdk

huguesdk commented Jun 8, 2026

Copy link
Copy Markdown
Member

added lost history (when the module was named cookingo_custom), fix a failing test and add a dependency to test-dependencies.txt to make tests pass.

@github-grap-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@huguesdk

huguesdk commented Jun 9, 2026

Copy link
Copy Markdown
Member

/ocabot merge nobump

@github-grap-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-382-by-huguesdk-bump-nobump, awaiting test results.

@github-grap-bot github-grap-bot merged commit 9ca321f into 16.0 Jun 9, 2026
2 checks passed
@github-grap-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 515a781. Thanks a lot for contributing to coopiteasy. ❤️

@github-grap-bot github-grap-bot deleted the 16.0-mig-container_meals branch June 9, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants