bugfix: "Invalid public key" when establishing a new OMEMO2 session#32
Merged
Conversation
`processPreKey` fed the bundle's signed prekey and prekey public keys straight to ECDHE. omemo:2 transfers these as raw 32-byte curve keys, which the version 2.0.1 DH hardening rejects with "Invalid public key". Normalize them to the internal 33-byte 0x05-prefixed form via a new `normalizeRemotePreKey` protocol-profile hook.
Now that protobufs are pre-generated, the functions to load them are sync. Remove unnecessary async from functions calling them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.