-tools: update library versions and fix torch installation#2850
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
mikebonnet
temporarily deployed
to
macos-installer
July 17, 2026 21:33 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (14)
🚧 Files skipped from review as they are similar to previous changes (11)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR updates CUDA, ROCm, and XPU build targets, generalizes backend-aware installation, refreshes accelerator and CPU dependency locks, and moves CUDA builds to the 12.9.2 base image. ChangesBackend toolchain refresh
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Tekton
participant build_tools.sh
participant uv
participant requirements-tools
Tekton->>build_tools.sh: pass backend build argument
build_tools.sh->>build_tools.sh: choose backend and architecture lockfile
build_tools.sh->>uv: install with Torch backend options
uv->>requirements-tools: resolve pinned backend requirements
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mikebonnet
force-pushed
the
cuda-rocm-versions
branch
from
July 17, 2026 22:01
fd6d1ee to
969610e
Compare
mikebonnet
temporarily deployed
to
macos-installer
July 17, 2026 22:01 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mikebonnet
force-pushed
the
cuda-rocm-versions
branch
from
July 17, 2026 22:09
969610e to
f398db7
Compare
mikebonnet
temporarily deployed
to
macos-installer
July 17, 2026 22:10 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mikebonnet
marked this pull request as ready for review
July 18, 2026 00:21
mikebonnet
requested review from
bmahabirbu,
cgruver,
engelmi,
jhjaggars,
maxamillion,
olliewalsh,
rhatdan and
swarajpande5
as code owners
July 18, 2026 00:21
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.tekton/cuda-tools/cuda-tools-pull-request.yaml:
- Around line 40-41: Update the on-cel-expression in
.tekton/cuda-tools/cuda-tools-pull-request.yaml (lines 40-41) to match cu129
requirement files instead of cu128. Also update the on-cel-expression in
.tekton/rocm-tools/rocm-tools-pull-request.yaml (lines 42-43) to reference
rocm7.1 instead of rocm6.3, preserving the existing pathChanged() trigger
behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 3dcaa185-2559-480b-8d2b-18105ffc8594
📒 Files selected for processing (14)
.tekton/cuda-tools/cuda-tools-pull-request.yaml.tekton/cuda-tools/cuda-tools-push.yaml.tekton/rocm-tools/rocm-tools-pull-request.yaml.tekton/rocm-tools/rocm-tools-push.yamlcontainer-images/common/Makefilecontainer-images/common/requirements-rag.txtcontainer-images/common/requirements-tools-cpu-aarch64.txtcontainer-images/common/requirements-tools-cpu.txtcontainer-images/common/requirements-tools-cu129-aarch64.txtcontainer-images/common/requirements-tools-cu129.txtcontainer-images/common/requirements-tools-rocm7.1.txtcontainer-images/common/requirements-tools-xpu.txtcontainer-images/cuda/Containerfilecontainer-images/scripts/build_tools.sh
Update cuda to 12.9 and rocm to 7.1, which matches the versions used in the llama.cpp images. Upgrade to Python 3.14 in the cuda-tools image, since it is now available from the RHEL-9 AppStream repos. Signed-off-by: Mike Bonnet <mikeb@redhat.com>
llama-cpp-scripts configures uv to install torch from the cpu index, overriding --torch-backend. Use the --no-sources-package option to disable that config and respect --torch-backend. Use --torch-backend in build_tools.sh to install from the same repo that was used for dependency resolution. Signed-off-by: Mike Bonnet <mikeb@redhat.com>
mikebonnet
force-pushed
the
cuda-rocm-versions
branch
from
July 18, 2026 02:04
f398db7 to
bf54136
Compare
mikebonnet
temporarily deployed
to
macos-installer
July 18, 2026 02:05 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
mikebonnet
enabled auto-merge
July 18, 2026 02:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
cudato 12.9 androcmto 7.1 in the -tools images, to match the versions used in the llama.cpp images.Override a config in
llama-cpp-scriptsto install accelerator-specifictorchlibraries into the -tools images.