Skip to content
This repository was archived by the owner on Aug 13, 2019. It is now read-only.

Wrapper for GtkFileChooserDialog#80

Open
shish wants to merge 3 commits into
conformal:masterfrom
shish:file-chooser
Open

Wrapper for GtkFileChooserDialog#80
shish wants to merge 3 commits into
conformal:masterfrom
shish:file-chooser

Conversation

@shish
Copy link
Copy Markdown

@shish shish commented Sep 6, 2014

A small finished subset of #59 with review comments taken into account (title / button strings for the dialog are freed at the end of the function)

@weberc2
Copy link
Copy Markdown
Contributor

weberc2 commented Sep 6, 2014

Awesome. I was just going to write this.

Comment thread gtk/gtk.go Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep consistency with other multiple-constructor functions, this should be named something like FileChooserDialogNewWith1Button(). Looks great otherwise!

@weberc2
Copy link
Copy Markdown
Contributor

weberc2 commented Sep 6, 2014

This looks great. Maybe this would be a good time to change FileChooser.Run()'s return type from int to ResponseType?

andre-hub pushed a commit to andre-hub/gotk3 that referenced this pull request Feb 13, 2016
Add support for GApplication and GNotification
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants