Skip to content

Add x-amz-server-side-encryption header for AES256 SSE without customer key#772

Open
Dan Feldman (85danf) wants to merge 1 commit into
confluentinc:masterfrom
85danf:85danf-fix-#770
Open

Add x-amz-server-side-encryption header for AES256 SSE without customer key#772
Dan Feldman (85danf) wants to merge 1 commit into
confluentinc:masterfrom
85danf:85danf-fix-#770

Conversation

@85danf

Copy link
Copy Markdown

Problem

See #770

Solution

The code in this PR adds the x-amz-server-side-encryption header in cases where SSE is configured to be AES256 but not customer key was provided.

Does this solution apply anywhere else?
  • yes
  • no
If yes, where?

The following versions (and onwards) are affected, I'm not sure about this repo's patch strategy so I opened it on the latest branch.

  • 10.5.6
  • 10.4.8
  • 10.3.10
  • 10.2.14
  • 10.1.15
  • 10.0.26

Test Strategy

Built locally and tested on our environment.

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Release Plan

@85danf Dan Feldman (85danf) requested a review from a team as a code owner August 8, 2024 08:19
@cla-assistant

cla-assistant Bot commented Aug 8, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@cla-assistant

cla-assistant Bot commented Aug 8, 2024

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@subhashiyer9

Copy link
Copy Markdown
Member

Dan Feldman (@85danf) Thanks for the fix.
Can you rebase to the oldest affected branch 10.0.x and update the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants