Add x-amz-server-side-encryption header for AES256 SSE without customer key#772
Open
Dan Feldman (85danf) wants to merge 1 commit into
Open
Add x-amz-server-side-encryption header for AES256 SSE without customer key#772Dan Feldman (85danf) wants to merge 1 commit into
Dan Feldman (85danf) wants to merge 1 commit into
Conversation
…S256 without customer key
|
|
Member
|
Dan Feldman (@85danf) Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
See #770
Solution
The code in this PR adds the
x-amz-server-side-encryptionheader in cases whereSSEis configured to beAES256but not customer key was provided.Does this solution apply anywhere else?
If yes, where?
The following versions (and onwards) are affected, I'm not sure about this repo's patch strategy so I opened it on the latest branch.
Test Strategy
Built locally and tested on our environment.
Testing done:
Release Plan