fix(initdata): reject combined certs in extra_root_certificates entries#46
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens initdata validate handling for cdh.toml’s image.extra_root_certificates by rejecting PEM bundles (multiple certificates) per array entry and adding a regression test to ensure the error clearly identifies the offending index.
Changes:
- Add validation to reject
extra_root_certificatesentries containing multiple certificates, with an error pointing to the specific array index. - Add a unit test ensuring a combined (bundled) certificate entry is rejected with the expected stderr content.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/initdata/common.go | Adds early parsing/counting of PEM certificates for image.extra_root_certificates entries and errors on bundles. |
| cmd/initdata/validate_test.go | Adds regression coverage asserting combined certificates in a single extra_root_certificates entry are rejected with a clear indexed message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+294
to
+296
| if len(certs) > 1 { | ||
| return nil, fmt.Errorf("%s: contains %d certificates; each array entry must contain exactly one certificate", source, len(certs)) | ||
| } |
Each array entry must contain exactly one certificate; bundles are now caught early with a clear error naming the offending index. Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each array entry must contain exactly one certificate; bundles are now caught early with a clear error naming the offending index.