Skip to content

Add a comment to specify both TDX/SNP build for veritas#22

Merged
bpradipt merged 1 commit into
confidential-devhub:mainfrom
bpradipt:tdx-comment
Apr 29, 2026
Merged

Add a comment to specify both TDX/SNP build for veritas#22
bpradipt merged 1 commit into
confidential-devhub:mainfrom
bpradipt:tdx-comment

Conversation

@bpradipt

Copy link
Copy Markdown
Contributor

No description provided.

Side-by fix: Update the pip install for ubi

Signed-off-by: Pradipta Banerjee <pradipta.banerjee@gmail.com>
@bpradipt bpradipt requested a review from Copilot April 29, 2026 16:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the container build documentation to clarify that the Veritas installation in both Fedora and UBI images is intended to support both TDX and SNP measurement workflows.

Changes:

  • Replace the existing Veritas install comment with wording that explicitly calls out SNP + TDX support.
  • Add a clarifying note about how TDX support is covered by the base install and SNP support is enabled via the [snp] extra.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Containerfile Updates the inline comment above the Veritas pip install to mention TDX + SNP support.
Containerfile.ubi Same comment update for the UBI-based image build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Containerfile.ubi Outdated
@bpradipt bpradipt merged commit 6e69aca into confidential-devhub:main Apr 29, 2026
1 check passed
@bpradipt bpradipt deleted the tdx-comment branch April 29, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants