kbs/token: Unwrap JSON object from string if found#959
Closed
tylerfanelli wants to merge 1 commit into
Closed
Conversation
The TEE public key is represented as a JSON object. However, some serialization libraries encode this object within a JSON string. If this is found, unwrap the object from the JSON string and then deserialize. Signed-off-by: Tyler Fanelli <tfanelli@redhat.com>
tylerfanelli
force-pushed
the
kbs-token-str-unwrap
branch
from
b925182 to
a724759
Compare
Xynnn007
reviewed
Sep 16, 2025
Xynnn007
left a comment
Xynnn007
left a comment
Member
There was a problem hiding this comment.
looks like this patch is a follow-up for #920. Any updates for #920 (comment) ? I still think it is more reasonable to change the serialization in the producer side.
Contributor
Author
|
This is a placeholder so #920 can move forward and be merged. Still looking into the producer issue. Marking as draft for now. |
Member
|
nit: #920 gets merged. |
Contributor
Author
|
I've proposed a fix for the producer in confidential-containers/kbs-types#75. This PR can be closed if that is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TEE public key is represented as a JSON object. However, some serialization libraries encode this object within a JSON string. If this is found, unwrap the object from the JSON string and then deserialize.