Skip to content

ci: set up native build for arm64 and kbs-client-image#769

Merged
huoqifeng merged 2 commits into
confidential-containers:mainfrom
seungukshin:arm64-native-build
Apr 25, 2025
Merged

ci: set up native build for arm64 and kbs-client-image#769
huoqifeng merged 2 commits into
confidential-containers:mainfrom
seungukshin:arm64-native-build

Conversation

@seungukshin

Copy link
Copy Markdown

Use native build for arm64 and remove the workaround for cross build
(confidential-containers#716)

Signed-off-by: Seunguk Shin <seunguk.shin@arm.com>
Reviewed-by: Nick Connolly <nick.connolly@arm.com>
Build and push kbs-client-image to ghcr to use it for trustee-operator's
kuttl integration tests.

Signed-off-by: Seunguk Shin <seunguk.shin@arm.com>
Reviewed-by: Nick Connolly <nick.connolly@arm.com>
@seungukshin seungukshin requested a review from a team as a code owner April 17, 2025 13:57

@Xynnn007 Xynnn007 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM. There is one comment that is related, but I think it will not block as this PR does not change anything in present upstream except for a new kbs client image.

WORKDIR /usr/src/kbs
COPY . .

RUN apt-get update && apt-get install -y pkg-config libssl-dev git sudo

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @fitzthum @bpradipt

This is something related to #764 (comment)

Note that in this PR the image to be built is "sample-only" for x86-64/s390x/aarch64

@fitzthum fitzthum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine in general. Do we need to add something to the release-helper script to tag a release version of this image?

@huoqifeng huoqifeng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huoqifeng huoqifeng merged commit cbf61a0 into confidential-containers:main Apr 25, 2025
queenie-sun-virtru pushed a commit to queenie-sun-virtru/trustee that referenced this pull request Jul 23, 2025
…-native-build

ci: set up native build for arm64 and kbs-client-image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants