ci: set up native build for arm64 and kbs-client-image#769
Merged
huoqifeng merged 2 commits intoApr 25, 2025
Conversation
Use native build for arm64 and remove the workaround for cross build (confidential-containers#716) Signed-off-by: Seunguk Shin <seunguk.shin@arm.com> Reviewed-by: Nick Connolly <nick.connolly@arm.com>
Build and push kbs-client-image to ghcr to use it for trustee-operator's kuttl integration tests. Signed-off-by: Seunguk Shin <seunguk.shin@arm.com> Reviewed-by: Nick Connolly <nick.connolly@arm.com>
Xynnn007
approved these changes
Apr 18, 2025
Xynnn007
left a comment
Member
There was a problem hiding this comment.
Thanks. LGTM. There is one comment that is related, but I think it will not block as this PR does not change anything in present upstream except for a new kbs client image.
| WORKDIR /usr/src/kbs | ||
| COPY . . | ||
|
|
||
| RUN apt-get update && apt-get install -y pkg-config libssl-dev git sudo |
Member
There was a problem hiding this comment.
This is something related to #764 (comment)
Note that in this PR the image to be built is "sample-only" for x86-64/s390x/aarch64
fitzthum
reviewed
Apr 18, 2025
fitzthum
left a comment
Member
There was a problem hiding this comment.
Looks fine in general. Do we need to add something to the release-helper script to tag a release version of this image?
queenie-sun-virtru
pushed a commit
to queenie-sun-virtru/trustee
that referenced
this pull request
Jul 23, 2025
…-native-build ci: set up native build for arm64 and kbs-client-image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghcr.io/confidential-containers/staged-images/kbs:latestandghcr.io/confidential-containers/staged-images/kbs-client-image:latestrespectively