Tee: add AsRef<str>, Display and from_str implementation#86
Merged
Conversation
Member
|
Tests sad. This will help us remove a couple places where we have to strip out the quotes from the serde deserialized string. |
Member
Author
|
@fitzthum fixed |
Collaborator
|
Did you consider using strum macros since this crate already pulls it? |
Member
Author
|
Oh I did not realize this is already imported so chose to impl it without importing more deps. Let me do a refactoring. |
Tee enum now can only be serde/deserde via serde-rs. In this way there will always be `"` around the serde-ed string, and always require `"` for the string to be de-serde. The patch helps to natively support ToString and FromString like traits using strum crate. Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tee enum now can only be serde/deserde via serde-rs. In this way there will always be
"around the serde-ed string, and always require"for the string to be de-serde.The patch helps to natively support ToString and FromString like traits.