bump rust toolchain to 1.85.1#1026
Merged
Merged
Conversation
mythi
force-pushed
the
rust-185
branch
2 times, most recently
from
June 16, 2025 07:21
9fd6729 to
a3d60cc
Compare
mythi
changed the title
mythi
marked this pull request as ready for review
June 16, 2025 07:22
Contributor
Author
|
Ready for review. |
Xynnn007
reviewed
Jun 16, 2025
Xynnn007
left a comment
Xynnn007
left a comment
Member
There was a problem hiding this comment.
Thanks. All look good. Only I think we can drop stable and introduce nightly in a same PR/commit. Otherwise, there is no CI for stable, which leads to the accumulation of many potential lint errors.
mkulke
reviewed
Jun 16, 2025
mkulke
left a comment
mkulke
left a comment
Contributor
There was a problem hiding this comment.
I found the broken stable build signal to be useful (more useful than beta & nightly), since you have to deal with those changes anyway eventually. We can maybe make the passing of a stable build not required for PR merges?
Contributor
Author
I'll see if I can get some simple |
mythi
force-pushed
the
rust-185
branch
2 times, most recently
from
June 17, 2025 10:00
6c87bf3 to
220968a
Compare
mkulke
reviewed
Jun 17, 2025
Change how rust is configured an used in our CI. The changes are: * bump the toolchain version pinning from 1.80.0 to 1.85.1 * move to use actions-rust-lang toolchain action since actions-rs is no longer maintained * drop 'stable' from CI test matrix since it's a moving target and sometimes makes CI to fail in case a new stable rust version adds new linter checks that fail with our code. This should move to nighly clippy check or similar. Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
Rust stable releases often add new lint checks that make guest-components packages to fail CI (we run with -D warnings). To avoid failing CI blocking PRs because rust stable CI checks won't pass, we pin to a fixed toolcain version. However, at the same time we want to be sure the code passes stable lint checks. Add a weekly non-blocking check using Rust stable to give us an indication if the code needs to be improved to comply with the latest stable lint checks. Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
mkulke
approved these changes
Jun 17, 2025
Xynnn007
merged commit Jun 18, 2025
22cb293
into
confidential-containers:main
30 of 31 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change how rust is configured an used in our CI. The changes are:
longer maintained
makes CI to fail in case a new stable rust version adds new linter checks
that fail with our code. This should move to nighly clippy check or similar.
Update: add another commit that adds a weekly check for
cargo clippyusing rust stable.