Repository navigation
ck_ec: test fixes for platforms where sizeof(time_t)!=sizeof(long) - #290
Merged
Merged
Conversation
In ck_ec tests, remove the assumption that `sizeof(time_t)==sizeof(long)`, and use a homebrewed int128 implementation rather than assuming the compiler itself has support for the `__int128` type. On Windows, `sizeof(long)==4` and `sizeof(time_t)==8`. GCC/Clang do not support `__int128` on 32-bit targets, and MSVC does not support it at all. - Fixes prop_test_timeutil_add, prop_test_timeutil_add_ns, prop_test_timeutil_cmp tests failing on Windows MinGW. - Fixes concurrencykit#208.
Contributor
|
Thanks a lot for doing this! Hopefully you won't have much more trouble on your quest to get it to properly run on Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ck_ec tests, remove the assumption that
sizeof(time_t)==sizeof(long), and use a homebrewed int128 implementation rather than assuming the compiler itself has support for the__int128type.On Windows,
sizeof(long)==4andsizeof(time_t)==8. GCC/Clang do not support__int128on 32-bit targets, and MSVC does not support it at all.