Update HTML outputs from Conan#20087
Merged
Merged
Conversation
AbrilRBS
commented
Jun 17, 2026
| selected = graph_data["nodes"][ids[0]] || global_edges[ids_edges[0]]; | ||
| let div = document.createElement('div'); | ||
| let f = Object.fromEntries(Object.entries(selected).filter(([_, v]) => v != null)); | ||
| let f = Object.fromEntries(Object.entries(selected)); |
Member
Author
There was a problem hiding this comment.
I was surprised by this null filtering when debugging #20073 so thought that it would be useful elsewhere
memsharded
approved these changes
Jun 17, 2026
czoido
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Add missing favicon to Conan html output.
Docs: Omit
The original idea comes from @ErniGH, I just took the chance for the next change to add them after being able to compress them enough
The important thing to note in this PR is that now you get the full trait information, which I think is useful
I can add code to hide it in the information for each node in the graph if desired