[POC] Preparing multi-file CMakeConfigDeps (Part 1)#20036
Merged
memsharded merged 8 commits intoJun 16, 2026
Conversation
memsharded
reviewed
May 29, 2026
franramirez688
force-pushed
the
frm/poc_refactor_cmakedeps
branch
from
b9d43de to
eeb2111
Compare
franramirez688
force-pushed
the
frm/poc_refactor_cmakedeps
branch
from
eeb2111 to
636fe27
Compare
franramirez688
changed the title
AbrilRBS
approved these changes
Jun 16, 2026
memsharded
approved these changes
Jun 16, 2026
memsharded
left a comment
memsharded
left a comment
Member
There was a problem hiding this comment.
I think this is ready, great 👍
| self._cmakedeps = cmakedeps | ||
| self._require = require | ||
| self._conanfile = conanfile | ||
| def __init__(self, filename, reference, consumer_conanfile, full_cpp_info, |
Member
There was a problem hiding this comment.
We can even abstract more in the future, like consumer_conanfile -> path_relativizator or the "folder" that it needs to relativize the paths. That way it is completely explicit that it is not getting any other information from that conanfile.
Can be done in the future, not necessary to do it now.
…figdeps_new.py Co-authored-by: James <memsharded@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: omit
Docs: omit
Pure refactor before moving this forward: #19681