Use ComputeSDK recording option for Browserbase sessions - #454
Open
spicysouvlaki wants to merge 1 commit into
Open
spicysouvlaki wants to merge 1 commit into
spicysouvlaki wants to merge 1 commit into
Conversation
Contributor License AgreementAll contributors are covered by a CLA. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
spicysouvlaki
marked this pull request as draft
September 19, 2026 00:04
The @computesdk/browserbase adapter maps `recording` to Browserbase's `browserSettings.recordSession`. These configs passed `recordSession` directly, which the adapter drops, so sessions were still created with Browserbase's default of recordSession: true. `enableNativeSelectPolyfill` is left in place. It is a real (undocumented) Browserbase browserSettings field that defaults to true, but the adapter has no mapping for it, so it is currently a no-op here and will start taking effect if the adapter gains passthrough. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
spicysouvlaki
force-pushed
the
fix/browserbase-recording-option
branch
from
September 19, 2026 00:36
b090bb1 to
ad41e2f
Compare
spicysouvlaki
marked this pull request as ready for review
September 19, 2026 00:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A correctness fix we noticed while looking at the Browserbase benchmark config.
The Browserbase configs passed
recordSession: false, but that is not a ComputeSDK session option.@computesdk/browserbasebuilds its request params field-by-field with no passthrough for unknown keys, so it was silently dropped: