roomdoo-locks-base: dedupe exceptions, fix LockOfflineError parent#20
Merged
Conversation
LockAPIError, LockNoPermissionError and LockOfflineError were each defined twice: once as LockError subclasses (added by the TTLock impl) and once as LockOperationError subclasses (added earlier). Python kept the latter, so the LockError copies were dead code and LockOfflineError ended up classed as a business-operation error. Collapse each to a single definition and move LockOfflineError back under LockError next to LockConnectionError: it is a transient/connectivity error the caller retries, not a business rejection. No behaviour change — nothing catches LockOperationError and every site raises these by name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problema
LockAPIError,LockNoPermissionErroryLockOfflineErrorestaban definidas dos veces enexceptions.py:LockError(añadidas en la implementación de TTLock, 2026-04-20)LockOperationError(añadidas antes, 2026-04-10)En Python gana la última definición del módulo → quedaban las de
LockOperationError, y las copiasLockErroreran código muerto. Efecto colateral:LockOfflineErrorquedaba clasificada como error de operación de negocio.Cambio
LockOfflineErrorvuelve bajoLockError, junto aLockConnectionError: es un error transitorio/de conectividad que el llamante reintenta, no un rechazo de negocio.LockAPIErroryLockNoPermissionErrorse mantienen bajoLockOperationError(lo que ya ganaba en runtime).Sin cambio de comportamiento
Nadie hace
except LockOperationErrorniisinstancede la jerarquía; todos los conectores (ttlock, tesa, omnitec, salto) las lanzan por nombre con mensaje, ypms_smartlock_basecapturaLockOfflineErrorpor nombre como transitorio. Verificado: jerarquía correcta, sin duplicados, mensajes preservados.