Repository navigation
Add the missing has_children flag for Ñuble (CL). - #252
Merged
Merged
Conversation
The region has 21 localities in CL-NB.json, but no has_children flag in CL.json. It was the only child file in the dataset without a flagged parent. Without the flag, SubdivisionRepository::hasData() gave a result that depended on the load order: getAll(['CL', 'NB']) returned the localities when called first, and nothing once CL was loaded. The formatter and the validator always load the country first, so localities in Ñuble were not resolved and not validated.
Contributor
|
Good catch, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The region has 21 localities in CL-NB.json, but no has_children flag in CL.json. It was the only child file in the dataset without a flagged parent.
Without the flag, SubdivisionRepository::hasData() gave a result that depended on the load order: getAll(['CL', 'NB']) returned the localities when called first, and nothing once CL was loaded. The formatter and the validator always load the country first, so localities in Ñuble were not resolved and not validated.