[OPIK-7496] [BE] fix: strip otel attribute rule prefix from saved key#7499
Merged
andrescrz merged 12 commits intoJul 21, 2026
Conversation
github-actions
Bot
added
java
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
albe2669
marked this pull request as draft
July 16, 2026 18:10
albe2669
marked this pull request as ready for review
July 17, 2026 09:30
andrescrz
reviewed
Jul 20, 2026
Contributor
Author
|
Thank you for the review @andrescrz |
andrescrz
reviewed
Jul 21, 2026
andrescrz
left a comment
andrescrz
left a comment
Member
There was a problem hiding this comment.
Hi @albe2669
I left follow-up comments on one of the open discussions and also some additional feedback.
The main issue is that CI is failing, and it seems caused by changes related to this PR. Some tests in OpenTelemetryResourceTest seems to be the failing.
Please take a look and make sure the new code doesn't cause any regression.
I'll review once the fixes are in place.
Thanks a lot for your contribution.
albe2669
force-pushed
the
strip-prefix-from-prefix-rules
branch
from
July 21, 2026 11:12
e9062f8 to
6b68657
Compare
albe2669
marked this pull request as draft
July 21, 2026 11:13
albe2669
marked this pull request as ready for review
July 21, 2026 12:06
andrescrz
approved these changes
Jul 21, 2026
andrescrz
left a comment
andrescrz
left a comment
Member
There was a problem hiding this comment.
Hi @albe2669
Thanks for the contribution! I reviewed the PR and everything looks good from my side. I've approved it, and all CI checks have passed successfully.
We'll merge it shortly, and the change will be included in the next Opik release.
Thanks again for contributing to Opik!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
In the otel ingestion endpoint there are a few prefix attributes:
outputopik.metadatagen_ai.usagegen_ai.inputgen_ai.outputgen_ai.toolgen_ai.agentgen_ai.requestgen_ai.responseWhich map into input, output or metadata. When matching the prefix rule the
enrichSpanAttributesmethod sets the value in the respective bucket to the attribute key. This means that the attribute:output: {"choices": [...]}, will be parsed as{"output": {"choices": [...]}}. Similarly,output.choices: [...]would parse as the same thing.This PR strips the prefix of the matched rule, if the outcome is
INPUT,OUTPUTorMETADATA. This will allow an OpenTelemetry trace to produce a trace that is significantly closer to a native Opik trace.Change checklist
Issues
AI-WATERMARK
AI-WATERMARK: [no]
Testing
mvn test