Optionally allow to split class attribute values into multiple lines#212
Optionally allow to split class attribute values into multiple lines#212thet wants to merge 2 commits into
Conversation
Split multiple class attribute values into multiple lines. Keep it single-lined, if there is only one value. And don't split Chameleon expressions.
Per default class attributes are not split into multiple lines. That's what most tools do and most people would expect. To split class attributes into multiple lines use the `--split-class` option on the CLI.
|
Coverage is 97.204% — thet/class-multiline into master. No base build found for |
There was a problem hiding this comment.
This will for the first time introduce a flag that controls how zpretty formats the file.
I do not think we should add it.
Either we go for always having class names split one per line or we never do that.
For me it is fine to have classes one per line, but I think this should be discussed with the community, also because it will cause a lot of broken dependabot PRs.
If we go for such a bold move, it might also be interesting to change that only if the line length is longer than a given amount of characters (that would even make the formatter fully compliant with the ZCML style guide, see #12).
But before deciding something on this I would like to hear more opinions.
3 participants
Multiline values for class attributes.
Split multiple class attribute values into multiple lines. Keep it
single-lined, if there is only one value. And don't split Chameleon
expressions.
Add a switch for multiline class attribute values.
Per default class attributes are not split into multiple lines. That's what
most tools do and most people would expect. To split class attributes into
multiple lines use the
--split-classoption on the CLI.