DRYD-2113 Search > Pinned Queries#356
Open
spirosdi wants to merge 10 commits into
Open
Conversation
…eleting in prefs state slice;
…avedSearchQuery in searchPage actions to populate the search form based on the snapshot;
…changing operator;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
It adds the Pinned Queries feature to the Advanced Search page. There are two buttons added in the top button bar:
Changes:
state.prefs.pinneQueries, reusing the existing prefs localStorage mechanism.PIN_QUERY,DELETE_PINNED_QUERY, actionspinQuery,deletePinnedQuery,loadPinnedQuery, and selectorgetPinnedQueries. Extending reducer cases. A pinned query contains the whole form state (keyword, record type, vocabulary, and the advanced conditions) so loading restores the form exactly.savePrefs()so changes persist immediately.SearchPinButton,PinnedQueriesButton,PinQueryModal,PinnedQueriesModalWhy are we doing this? (with JIRA link)
Users have asked for the ability to save advanced search query parameters and re-run them later. https://collectionspace.atlassian.net/browse/DRYD-2113
How should this be tested? Do these changes have associated tests?
Unit tests were added.
For manual testing:
Dependencies for merging? Releasing to production?
No dependencies. Only a left TODO, we need to add the link to the user manual in the pinned queries modal.
Has the application documentation been updated for these changes?
Changelog has been updated
Did someone actually run this code to verify it works?
@spirosdi ran it locally.
Have any new accessibility violations been handled?
Changes have been checked with the WAVE browser extension and all issues have been handled.