Closes #204 - Add WebSerial support.#205
Conversation
|
Hi @patrykwegrzyn, thanks so much for this PR. I'm swamped at the moment but will definitely take a close look and review this as soon as I can. It looks like your editor maybe has automatically reformatted a number of files that you probably didn't mean to change. Can you make sure any white space changes etc. are omitted from your PR so that it's easier to review what has actually changed? Thanks so much! |
|
Hi @colinbdclark can you let me know what settings you are using ? im using prettier with standard settings i may be able to and do it but it may be painful. |
| oscWeb: [ | ||
| "src/osc-transports.js", | ||
| "src/platforms/osc-websocket-client.js", | ||
| "src/platforms/osc-web-serialport.js", |
There was a problem hiding this comment.
I only changed this in a Grunt file
| */ | ||
|
|
||
| /*global WebSerial, require*/ | ||
| var osc = osc || require("../osc.js"); |
There was a problem hiding this comment.
Followed your template and added new file to enable WebSerial support
| }()); | ||
| QUnit.test("Serial port support is not loaded", function () { | ||
| QUnit.expect(1); | ||
| QUnit.ok(osc.supportsSerial); |
There was a problem hiding this comment.
I modified this line to get tests to pass.
|
Hi, just checking if this PR will ever get accepted? I am getting a lot of Webpack 5 issues due to polyfill not being supported anymore. I can revert but, would love to upgrade my project |
|
Hi @ahfontaine, I am in the midst of a big career transition that has been occupying my time recently, but the good news is that I anticipate having more time to focus on my open source projects soon. I'm sorry for the delay with this, and do have the intention of reviewing and merging when life permits. |
|
@colinbdclark Any updates on this? |
4 participants
Hi @colinbdclark i'm not familiar with testing framework you are using so this may need some work on your end.
Please review and let me know if is anything else i can do to help.
Best regards
Pat